Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Return identity for MultiscaleImage transform to/from level 0 #3323

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Nov 13, 2024

The to/from level 0 transform is always the identity transform. Return the IdentityTransform class instead of the more generic ScaleTransform with ones for the scale factors.

Return the `IdentityTransform` when the user asks for the transform from
the resolution level 0 array.
@jp-dark jp-dark changed the title Update return for MultiscaleImage transform to/from level 0 [python] Return identity for MultiscaleImage transform to/from level 0 Nov 13, 2024
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (3d83782) to head (722a238).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3323      +/-   ##
==========================================
+ Coverage   85.19%   85.31%   +0.11%     
==========================================
  Files          53       53              
  Lines        5565     5569       +4     
==========================================
+ Hits         4741     4751      +10     
+ Misses        824      818       -6     
Flag Coverage Δ
python 85.31% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.31% <100.00%> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark merged commit 29eb565 into main Nov 13, 2024
11 checks passed
@jp-dark jp-dark deleted the dark/fix-level-0-transform branch November 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants